| Commit message (Expand) | Author | Age | Files | Lines |
|---|
| ... | |
| * | ui-clone.c: Fix path check•••The starts_with() check was broken in two ways: For one thing, the
parameters were passed in the wrong order, for another thing,
starts_with() returns 1 if the string starts with the prefix (not 0).
Note that this bug existed since commit 02a545e (Add support for cloning
over http, 2008-08-06) but only pops in in corner cases.
Signed-off-by: Lukas Fleischer <cgit@cryptocrack.de>
| Lukas Fleischer | 2015-02-09 | 1 | -2/+2 |
| * | git: update for v2.3.0•••* sort_string_list(): rename to string_list_sort() (upstream commit
3383e199)
* update read_tree_recursive callback to pass strbuf as base (upstream
commit 6a0b0b6d)
Signed-off-by: Christian Hesse <mail@eworm.de>
| Christian Hesse | 2015-02-08 | 6 | -23/+19 |
| * | ui-shared.c: Refactor add_clone_urls()•••Make use of strbuf_split_str() and strbuf lists to split clone URLs.
Signed-off-by: Lukas Fleischer <cgit@cryptocrack.de>
| Lukas Fleischer | 2015-02-05 | 1 | -22/+10 |
| * | Add repo.hide and repo.ignore•••These options can be used to hide a repository from the index or
completely ignore a repository, respectively. They are particularly
useful when used in combination with scan-path.
Signed-off-by: Lukas Fleischer <cgit@cryptocrack.de>
| Lukas Fleischer | 2015-01-29 | 5 | -0/+23 |
| * | Add Etags for snapshots | Janus | 2015-01-28 | 1 | -0/+1 |
| * | tag: reference with "h" instead of "id"•••When clicking on "log" from a tag we end up showing the log of whatever
branch we used to reach the tag. If the tag doesn't point onto a branch
then the tagged commit won't appear in this output.
By linking to tags with the head parameter instead of the "id" parameter
the log link will show the log of the tag. This is clearly desirable
when the tag has been reached from the refs UI and changing the
behaviour for tag decorations makes them match branch decorations where
log -> decoration -> log shows the log of the decoration.
Reported-by: Ferry Huberts <mailings@hupie.com>
Signed-off-by: John Keeping <john@keeping.me.uk>
| John Keeping | 2015-01-19 | 4 | -9/+8 |
| * | Return proper HTTP response when accessing info/•••Currently, when a user directly accesses the info command of a
repository, we exit cgit without printing anything to stdout, bringing
up error messages like "502 Bad Gateway" or "An error occurred while
reading CGI reply (no response received)". Instead of bailing out, at
least print the HTTP headers, including a reasonable error message.
Reported-by: Janus Troelsen
Signed-off-by: Lukas Fleischer <cgit@cryptocrack.de>
| Lukas Fleischer | 2015-01-15 | 1 | -1/+3 |
| * | git: update to v2.2.2•••Update to git version v2.2.2, no changes required.
Signed-off-by: Christian Hesse <mail@eworm.de>
| Christian Hesse | 2015-01-13 | 2 | -1/+1 |
| * | ui-diff: don't link to single file diff stat•••Seeing the diff stat for a single file is pretty useless, so reset the
diff type before generating the links to individual files in the diff
stat so that the links will show a useful diff.
Reported-by: Konstantin Ryabitsev <mricon@kernel.org>
Signed-off-by: John Keeping <john@keeping.me.uk>
| John Keeping | 2014-12-30 | 1 | -0/+10 |
| * | ui-patch: match git-format-patch(1) output•••Using (DIFF_FORMAT_DIFFSTAT | DIFF_FORMAT_PATCH) causes Git to emit a
"---" line between the commit message and the body of the patch, which
fixes a regression introduced in commit 455b598 (ui-patch.c: Use
log_tree_commit() to generate diffs, 2013-08-20), prior to which we
inserted the "---" line ourselves.
DIFF_FORMAT_SUMMARY is added so that we match the output of
git-format-patch(1) without the "-p" option.
Signed-off-by: John Keeping <john@keeping.me.uk>
| John Keeping | 2014-12-28 | 2 | -3/+4 |
| * | t0108: modernize style•••* &&-chaining
* use test_cmp instead of cmp
* use strip_headers instead of knowing how many lines there will be
Signed-off-by: John Keeping <john@keeping.me.uk>
| John Keeping | 2014-12-28 | 1 | -10/+10 |
| * | Revert "git: use xz compressed archive for download"•••This reverts commit a87c9d8a9779eab0499efd3c44e090a28c7d1cdf.
We want to make OpenBSD people happy.
| Jason A. Donenfeld | 2014-12-24 | 1 | -2/+2 |
| * | Use split_ident_line() in parse_user()•••Use Git's built-in ident line splitting algorithm instead of
reimplementing it. This does not only simplify the code but also makes
sure that cgit is consistent with Git when it comes to author parsing.
Signed-off-by: Lukas Fleischer <cgit@cryptocrack.de>
| Lukas Fleischer | 2014-12-24 | 1 | -28/+17 |
| * | footer: link back to cgit home page•••The footer has always been overrideable using the footer= in cgitrc, so
this won't anger anybody who cares about their footer.
| Jason A. Donenfeld | 2014-12-23 | 2 | -1/+8 |
| * | ui-shared: show absolute time in tooltip for relative dates•••Signed-off-by: John Keeping <john@keeping.me.uk>
| John Keeping | 2014-12-23 | 1 | -12/+23 |
| * | git: use xz compressed archive for download | Christian Hesse | 2014-12-23 | 1 | -2/+2 |
| * | match other common markdown file extensions | Chris Burroughs | 2014-12-23 | 1 | -1/+1 |
| * | repolist: add owner-filter•••This allows custom links to be used for repository owners by
configuring a filter to be applied in the "Owner" column in the
repository list.
| Chris Burroughs | 2014-12-23 | 7 | -8/+64 |
| * | ui-shared: add rel-vcs microformat links to HTML header•••As described at https://joeyh.name/rfc/rel-vcs/.
Signed-off-by: John Keeping <john@keeping.me.uk>
| John Keeping | 2014-12-23 | 1 | -0/+11 |
| * | ui-summary: add "rel='vcs-git'" to clone URL links•••This is described in the rel-vcs microformat[1].
[1] https://joeyh.name/rfc/rel-vcs/
Signed-off-by: John Keeping <john@keeping.me.uk>
| John Keeping | 2014-12-23 | 1 | -2/+4 |
| * | Extract clone URL printing to ui-shared.c•••This will allow us to reuse the same logic to add clone URL <link/>
elements to the header of all repo-specific pages in order to support
the rel-vcs microformat.
Signed-off-by: John Keeping <john@keeping.me.uk>
| John Keeping | 2014-12-23 | 3 | -46/+51 |
| * | Remove trailing slash after remove-suffix•••When removing the ".git" suffix of a non-bare repository, also remove
the trailing slash for compatibility with cgit_repobasename().
Signed-off-by: Lukas Fleischer <cgit@cryptocrack.de>
| Lukas Fleischer | 2014-12-23 | 1 | -3/+6 |
| * | git: update to v2.2.1•••Update to git version v2.2.1, including API changes.
Signed-off-by: Christian Hesse <mail@eworm.de>
| Christian Hesse | 2014-12-23 | 5 | -7/+8 |
| * | filter: fix libravatar email-filter https issue•••Serving cgit via https and getting avatar via http gives error messages
about untrusted content. This decides whether or not to use https link
by looking at the environment variable HTTPS, which is set in CGI.
| Christian Hesse | 2014-12-13 | 1 | -1/+2 |
| * | ui-diff: add "stat only" diff type•••This prints the diffstat but stops before printing (or generating) any
of the body of the diff.
No cgitrc option is added here so that we can wait to see how useful
this is before letting people set it as the default.
Suggested-by: Konstantin Ryabitsev <mricon@kernel.org>
Signed-off-by: John Keeping <john@keeping.me.uk>
| John Keeping | 2014-12-13 | 2 | -1/+5 |
| * | Change "ss" diff flag to an enum•••This will allow us to introduce a new "stat only" diff mode without
needing an explosion of mutually incompatible flags.
The old "ss" query parameter is still accepted in order to avoid
breaking saved links, but we no longer generate any URIs using it;
instead the new "dt" (diff type) parameter is used.
Signed-off-by: John Keeping <john@keeping.me.uk>
| John Keeping | 2014-12-13 | 4 | -14/+24 |
| * | ui-shared: remove toggle_ssdiff arg to cgit_diff_link()•••This argument is never used with a value other than zero, so remove it
and simplify the code.
Signed-off-by: John Keeping <john@keeping.me.uk>
| John Keeping | 2014-12-13 | 4 | -8/+8 |
| * | ui-shared: remove toggle_ssdiff arg to cgit_commit_link()•••This argument is never used with a value other than zero, so remove it
and simplify the code.
Signed-off-by: John Keeping <john@keeping.me.uk>
| John Keeping | 2014-12-13 | 5 | -13/+11 |
| * | git: update to v2.0.4•••No CGit changes required.
Signed-off-by: John Keeping <john@keeping.me.uk>
| John Keeping | 2014-08-07 | 2 | -1/+1 |
| * | Always check if README exists in choose_readme()•••Specifying a nonexistent README file via the readme option is sometimes
useful, e.g. when using scan-path and setting a global default.
Currently, we check whether there is only one option in the readme
option and, if so, we choose that file without checking whether it
exists. As a consequence, all repositories are equipped with an about
link in the aforementioned scenario, even if there is no about file.
Remove the early check for the number of keys and always check whether
the file exists instead.
Signed-off-by: Lukas Fleischer <cgit@cryptocrack.de>
| Lukas Fleischer | 2014-08-07 | 1 | -6/+0 |
| * | cgitrc.5: we mean a cgi response, not request | Jason A. Donenfeld | 2014-08-01 | 1 | -1/+1 |
| * | ui-stats.c: set parent pointer to NULL after freeing it•••We do this everywhere else, so we should be doing it here as well.
Signed-off-by: John Keeping <john@keeping.me.uk>
| John Keeping | 2014-07-28 | 1 | -0/+1 |
| * | git: update to v2.0.3•••This is slightly more involved than just bumping the version number
because it pulls in a change to convert the commit buffer to a slab,
removing the "buffer" field from "struct commit". All sites that access
"commit->buffer" have been changed to use the new functions provided for
this purpose.
Signed-off-by: John Keeping <john@keeping.me.uk>
| John Keeping | 2014-07-28 | 6 | -9/+7 |
| * | parsing.c: make commit buffer const•••This will be required in order to incorporate the changes to commit
buffer handling in Git 2.0.2.
Signed-off-by: John Keeping <john@keeping.me.uk>
| John Keeping | 2014-07-28 | 1 | -4/+4 |
| * | Bump version. | Jason A. Donenfeld | 2014-06-30 | 1 | -1/+1 |
| * | remove debug fprinf() calls that sneaked in with commit 79c985 | Christian Hesse | 2014-06-29 | 1 | -4/+0 |
| * | git: update to 2.0.1•••Everything works just bumping the version in Makefile and commit hash in
submodule. No code changes required.
| Christian Hesse | 2014-06-28 | 2 | -1/+1 |
| * | ui-patch: Flush stdout after outputting data•••It looks like cached patches are truncated to the nearest 1024-byte
boundary in the patch body. E.g.:
> mricon@nikko:[/tmp]$ wget -O no-cache
> "http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/patch/?id=6e1b4fdad5157bb9e88777d525704aba24389bee"
...
> 2014-06-11 15:34:51 (80.4 MB/s) - ‘no-cache’ saved [4767]
Patch is complete, without truncation. Next hit, with cache in place:
> mricon@nikko:[/tmp]$ wget -O yes-cache
> "http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/patch/?id=6e1b4
> fdad5157bb9e88777d525704aba24389bee"
...
> 2014-06-11 15:35:01 (17.0 MB/s) - ‘yes-cache’ saved [4096/4096]
Length truncated to 4096. The cache on disk looks truncated as well, so
the bug must me during the process of saving cache. The same is true for
larger patches:
> mricon@nikko:[/tmp]$ wget -O no-cache
> "http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/patch/?id=2840c566e95599cd60c7143762ca8b49d9395050"
...
> 2014-06-11 15:41:33 (1.07 MB/s) - ‘no-cache’ saved [979644]
979644 bytes with a cache-miss
> mricon@nikko:[/tmp]$ wget -O yes-cache
> "http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/patch/?id=2840c
> 566e95599cd60c7143762ca8b49d9395050"
...
> 2014-06-11 15:41:46 (1.05 MB/s) - ‘yes-cache’ saved [978944]
978944 (956KB exactly) with a cache-hit
Since the "html" functions use raw write(2) to STDIO_FILENO, we don't
notice problems with most pages, but raw patches write using printf(3).
This is fine if we're outputting straight to stdout since the buffers
are flushed on exit, but we close the cache output before this, so the
cached output ends up being truncated.
Make sure the buffers are flushed when we finish outputting a patch so
that we avoid this.
No other UIs use printf(3) so we do not need to worry about them.
Actually, it's slightly more interesting than this... since we don't set
GIT_FLUSH, Git decides whether or not it will flush stdout after writing
each commit based on whether or not stdout points to a regular file (in
maybe_flush_or_die()).
Which means that when writing directly to the webserver, Git flushes
stdout for us, but when we redirect stdout to the cache it points to a
regular file so Git no longer flushes the output for us.
The patch is still correct, but perhaps the full explanation is
interesting!
Reported-by: Konstantin Ryabitsev <mricon@kernel.org>
| John Keeping | 2014-06-28 | 1 | -0/+2 |
| * | ui-log: ignore unhandled arguments•••If you search for a bogus range string here:
http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/log/
Using something like "range" and "qwerty123456", it returns an "Internal
Server Error" and the following in the logs:
> [Tue Jun 10 17:45:32 2014] [error] [client 172.21.1.6] fatal:
> ambiguous argument 'qwerty123456': unknown revision or path not in the
> working tree., referer:
> http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/
> [Tue Jun 10 17:45:32 2014] [error] [client 172.21.1.6] Use '--' to
> separate paths from revisions, like this:, referer:
> http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/
> [Tue Jun 10 17:45:32 2014] [error] [client 172.21.1.6] 'git <command>
> [<revision>...] -- [<file>...]', referer:
> http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/
> [Tue Jun 10 17:45:32 2014] [error] [client 172.21.1.6] Premature end
> of script headers: cgit, referer:
> http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/
The cache will kick in, so if you search for the same string again,
it'll show an empty range, so you have to change the bogus strings each
time.
This is because we just pass the arguments straight to Git's revision
parsing machinery which die()s if it cannot parse an argument, printing
the above to stderr and exiting.
The patch below makes it a bit friendlier by just ignoring unhandled
arguments, but I can't see an easy way to report errors when we can't
parse revision arguments without losing the flexibility of supporting
all of the revision specifiers supported by Git.
Reported-by: Konstantin Ryabitsev <mricon@kernel.org>
| John Keeping | 2014-06-28 | 1 | -3/+3 |
| * | git: update for git 2.0•••prefixcmp() and suffixcmp() have been remove, functionality is now
provided by starts_with() and ends_with(). Retrurn values have been
changed, so instead of just renaming we have to fix logic.
Everything else looks just fine.
| Christian Hesse | 2014-06-28 | 12 | -36/+40 |
| * | remove trailing whitespaces from source files | Christian Hesse | 2014-04-17 | 6 | -24/+24 |
| * | git: update to 1.9.2•••Everything works just bumping the version in Makefile and commit hash in
submodule. No code changes required.
| Christian Hesse | 2014-04-12 | 2 | -1/+1 |
| * | Fix cgit_parse_url when a repo url is contained in another repo url•••For example, if I have two repos (remove-suffix is enabled):
/foo
/foo/bar
http://cgit/foo/bar/ is interpreted as "repository 'foo', command 'bar'"
instead of "repository 'foo/bar'"
| Julian Maurice | 2014-04-05 | 1 | -9/+14 |
| * | Makefile: use more reliable git tarball mirror | Jason A. Donenfeld | 2014-03-20 | 1 | -1/+1 |
| * | git: update to 1.9.1•••Everything works just bumping the version in Makefile and commit hash
in submodule. No code changes required.
| Christian Hesse | 2014-03-20 | 2 | -1/+1 |
| * | filter: add libravatar email-filter lua script | Christian Hesse | 2014-03-13 | 1 | -0/+26 |
| * | Bump version. | Jason A. Donenfeld | 2014-02-28 | 1 | -1/+1 |
| * | ui-refs: simplify cmp_age logic•••The check in parse_user that eventually makes it into committer_date and
tagger_date is:
else if (mode == 3 && isdigit(*p)) {
*date = atol(p);
mode++;
}
Since isdigit('-') is always false, date will never be negative. Thus
the sign of this function:
static int cmp_age(int age1, int age2)
{
if (age1 != 0 && age2 != 0)
return age2 - age1;
if (age1 == 0 && age2 == 0)
return 0;
if (age1 == 0)
return +1;
return -1;
}
Will always be the same as the sign of this function:
static inline int cmp_age(int age1, int age2)
{
return age2 - age1;
}
Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
Idea-by: Lukas Fleischer <cgit@cryptocrack.de>
| Jason A. Donenfeld | 2014-02-26 | 1 | -11/+3 |
| * | Remove unused parameter from cgit_print_snapshot() | Lukas Fleischer | 2014-02-21 | 3 | -3/+3 |
| * | print download link for reference string length == 1•••I have a number of repositories that start tagging with just '1' and
count up. Actually references with sting length of one are skipped, this
patch changes that.
| Christian Hesse | 2014-02-21 | 1 | -1/+1 |
