| Commit message (Expand) | Author | Age | Files | Lines |
|---|
| * | filter: add gravatar scripts•••The lua one is hugely faster than the python one, but both are included
for comparison.
Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
| Jason A. Donenfeld | 2014-01-14 | 2 | -0/+58 |
| * | filter: add support for email filter•••Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
| Jason A. Donenfeld | 2014-01-14 | 9 | -2/+47 |
| * | filter: return on null filter from open and close•••So that we don't have to include the if(filter) open_filter(filter)
block everywhere, we introduce the guard in the function itself. This
should simplify quite a bit of code.
Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
| Jason A. Donenfeld | 2014-01-14 | 4 | -22/+14 |
| * | filter: add lua support•••Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
| Jason A. Donenfeld | 2014-01-14 | 4 | -3/+235 |
| * | filter: basic write hooking infrastructure•••Filters can now call hook_write and unhook_write if they want to
redirect writing to stdout to a different function. This saves us from
potential file descriptor pipes and other less efficient mechanisms.
We do this instead of replacing the call in html_raw because some places
stdlib's printf functions are used (ui-patch or within git itself),
which has its own internal buffering, which makes it difficult to
interlace our function calls. So, we dlsym libc's write and then
override it in the link stage.
While we're at it, we move considerations of argument count into the
generic new filter handler.
Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
| Jason A. Donenfeld | 2014-01-14 | 4 | -23/+67 |
| * | filter: allow for cleanup hook for filter types•••At some point, we're going to want to do lazy deallocation of filters.
For example, if we implement lua, we'll want to load the lua runtime
once for each filter, even if that filter is called many times.
Similarly, for persistent exec filters, we'll want to load it once,
despite many open_filter and close_filter calls, and only reap the child
process at the end of the cgit process. For this reason, we add here a
cleanup function that is called at the end of cgit's main().
Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
| Jason A. Donenfeld | 2014-01-14 | 3 | -27/+66 |
| * | filter: introduce "filter type" prefix•••This allows different filter implementations to be specified in the
configuration file. Currently only "exec" is supported, but it may now
be specified either with or without the "exec:" prefix.
Signed-off-by: John Keeping <john@keeping.me.uk>
| John Keeping | 2014-01-14 | 2 | -2/+40 |
| * | filter: add interface layer•••Change the existing cgit_{open,close,fprintf}_filter functions to
delegate to filter-specific implementations accessed via function
pointers on the cgit_filter object.
We treat the "exec" filter type slightly specially here by putting its
structure definition in the header file and providing an "init" function
to set up the function pointers. This is required so that the
ui-snapshot.c code that applies a compression filter can continue to use
the filter interface to do so.
Signed-off-by: John Keeping <john@keeping.me.uk>
| John Keeping | 2014-01-14 | 3 | -22/+63 |
| * | filter: add fprintf_filter function•••This stops the code in cgit.c::print_repo needing to inspect the
cgit_filter structure, meaning that we can abstract out different filter
types that will have different fields that need to be printed.
Signed-off-by: John Keeping <john@keeping.me.uk>
| John Keeping | 2014-01-14 | 3 | -3/+9 |
| * | authors: specify maintainers•••Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
| Jason A. Donenfeld | 2014-01-14 | 1 | -6/+13 |
| * | filters: Improved syntax-highlighting.py•••- Switched back to python2 according to a problem in pygments with python3.
With the next release of pygments this problem should be fixed.
Issue see here:
https://bitbucket.org/birkenfeld/pygments-main/issue/901/problems-with-python3
- Just read the stdin, decode it to utf-8 and ignore unknown signs. This ensures
that even destroyed files do not cause any errors in the filter.
- Improved language guessing:
-> At first use guess_lexer_for_filename for a better detection of the used
programming languages (even mixed cases will be detected, e.g. php + html).
-> If nothing was found look if there is a shebang and use guess_lexer.
-> As default/fallback choose TextLexer.
Signed-off-by: Stefan Tatschner <stefan@sevenbyte.org>
| Stefan Tatschner | 2014-01-13 | 1 | -19/+33 |
| * | tests: add CGIT_TEST_OPTS variable to Makefile•••This allows running the entire test suite with a set of command-line
options. For example:
make test CGIT_TEST_OPTS=--valgrind
Signed-off-by: John Keeping <john@keeping.me.uk>
| John Keeping | 2014-01-12 | 1 | -1/+1 |
| * | ui-repolist: HTML-escape cgit_rooturl() response•••This is for consistency with other callers. The value returned from
cgit_rooturl is not guaranteed to be HTML-safe.
Signed-off-by: John Keeping <john@keeping.me.uk>
| John Keeping | 2014-01-12 | 1 | -1/+3 |
| * | ui-shared: URL-escape script_name•••As far as I know, there is no requirement that $SCRIPT_NAME contain only
URL-safe characters, so we need to make sure that any special characters
are escaped.
Signed-off-by: John Keeping <john@keeping.me.uk>
| John Keeping | 2014-01-12 | 1 | -2/+2 |
| * | ui-refs: escape HTML chars in author and tagger names•••Everywhere else we use html_txt to escape any special characters in
these variables. Do so here as well.
Signed-off-by: John Keeping <john@keeping.me.uk>
| John Keeping | 2014-01-12 | 1 | -2/+2 |
| * | filter: pass extra arguments via cgit_open_filter•••This avoids poking into the filter data structure at various points in
the code. We rely on the fact that the number of arguments is fixed
based on the filter type (set in cgit_new_filter) and that the call
sites all know which filter type they're using.
Signed-off-by: John Keeping <john@keeping.me.uk>
| John Keeping | 2014-01-12 | 5 | -30/+38 |
| * | ui-snapshot: set unused cgit_filter fields to zero•••By switching the assignment of fields in the cgit_filter structure to
use designated initializers, the compiler will initialize all other
fields to their default value. This will be needed when we add the
extra_args field in the next patch.
Signed-off-by: John Keeping <john@keeping.me.uk>
| John Keeping | 2014-01-12 | 1 | -4/+4 |
| * | html: remove redundant htmlfd variable•••This is never changed from STDOUT_FILENO, so just use that value
directly.
Signed-off-by: John Keeping <john@keeping.me.uk>
| John Keeping | 2014-01-12 | 1 | -3/+1 |
| * | tests: add Valgrind support•••Now running tests with the "--valgrind" option will run cgit under
Valgrind instead of all Git commands.
Signed-off-by: John Keeping <john@keeping.me.uk>
| John Keeping | 2014-01-12 | 2 | -1/+48 |
| * | cache: don't leave cache_slot fields uninitialized•••Valgrind says:
==18344== Conditional jump or move depends on uninitialised value(s)
==18344== at 0x406C83: open_slot (cache.c:63)
==18344== by 0x407478: cache_ls (cache.c:403)
==18344== by 0x404C9A: process_request (cgit.c:639)
==18344== by 0x406BD2: fill_slot (cache.c:190)
==18344== by 0x4071A0: cache_process (cache.c:284)
==18344== by 0x404461: main (cgit.c:952)
==18344== Uninitialised value was created by a stack allocation
==18344== at 0x40738B: cache_ls (cache.c:375)
This is caused by the keylen field being used to calculate whether or
not a slot is matched. We never then check the value of this and the
length of data read depends on the key length read from the file so this
isn't dangerous, but it's nice to avoid branching based on uninitialized
data.
Signed-off-by: John Keeping <john@keeping.me.uk>
| John Keeping | 2014-01-12 | 1 | -1/+1 |
| * | filter: split filter functions into their own file•••A first step for more interesting things.
Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
| Jason A. Donenfeld | 2014-01-10 | 5 | -71/+90 |
| * | filter: make exit status local•••It's only used in one place, and not useful to have around since
close_filter will die() if exit_status isn't what it expects, anyway. So
this is best as just a local variable instead of as part of the struct.
Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
| Jason A. Donenfeld | 2014-01-10 | 2 | -4/+4 |
| * | parsing: fix header typo | Jason A. Donenfeld | 2014-01-10 | 1 | -1/+1 |
| * | cgit.c: Fix comment on bit mask hack•••* Formatting and spelling fixes.
* A bit mask with the size of one byte only allows for storing 8 (not
255!) different flags.
Signed-off-by: Lukas Fleischer <cgit@cryptocrack.de>
| Lukas Fleischer | 2014-01-10 | 1 | -8/+10 |
| * | cgit.c: Use "else" for mutually exclusive branches•••When parsing command line arguments, no pair of command line options can
ever match simultaneously. Use "else if" blocks to reflect this. This
change improves both readability and speed.
Signed-off-by: Lukas Fleischer <cgit@cryptocrack.de>
| Lukas Fleischer | 2014-01-10 | 1 | -19/+10 |
| * | ui-snapshot.c: Do not reinvent suffixcmp()•••Use suffixcmp() from Git instead of reimplementing it. This is a
preparation for moving to ends_with() in Git 1.8.6.
Signed-off-by: Lukas Fleischer <cgit@cryptocrack.de>
| Lukas Fleischer | 2014-01-10 | 1 | -6/+1 |
| * | Refactor cgit_parse_snapshots_mask()•••Use Git string lists instead of str{spn,cspn,ncmp}() magic. This
significantly improves readability.
Signed-off-by: Lukas Fleischer <cgit@cryptocrack.de>
| Lukas Fleischer | 2014-01-10 | 1 | -11/+12 |
| * | Disallow use of undocumented snapshot delimiters•••Since the introduction of selective snapshot format configuration in
dc3c9b5 (allow selective enabling of snapshots, 2007-07-21), we allowed
seven different delimiters for snapshot formats, while the documentation
has always been clear about spaces being the only valid delimiter:
The value is a space-separated list of zero or more of the values
"tar", "tar.gz", "tar.bz2", "tar.xz" and "zip".
Supporting the undocumented delimiters makes the code unnecessarily
complex. Remove them.
Signed-off-by: Lukas Fleischer <cgit@cryptocrack.de>
| Lukas Fleischer | 2014-01-10 | 1 | -1/+1 |
| * | Replace most uses of strncmp() with prefixcmp()•••This is a preparation for replacing all prefix checks with either
strip_prefix() or starts_with() when Git 1.8.6 is released.
Signed-off-by: Lukas Fleischer <cgit@cryptocrack.de>
| Lukas Fleischer | 2014-01-10 | 6 | -20/+20 |
| * | README: Fix dependencies•••* Remove the dependency on Git (which can be obtained automatically when
building, using either the Git submodule or `make get-git`).
* Use proper upstream names of dependencies.
Signed-off-by: Lukas Fleischer <cgit@cryptocrack.de>
| Lukas Fleischer | 2014-01-09 | 1 | -4/+3 |
| * | README: Spelling and formatting fixes•••* Several small spelling and capitalization fixes.
* Use consistent and better-looking formatting that is compatible with
AsciiDoc (and partly compatible with RST).
Signed-off-by: Lukas Fleischer <cgit@cryptocrack.de>
| Lukas Fleischer | 2014-01-08 | 1 | -41/+41 |
| * | Fix UTF-8 with syntax-highlighting.py•••Previously the script tried to encode output from Pygments with
the ASCII codec, which failed.
Signed-off-by: Přemysl Janouch <p.janouch@gmail.com>
| Přemysl Janouch | 2014-01-08 | 1 | -0/+1 |
| * | Add a suggestion to the manpage•••So that people wishing to use "enable-http-clone" don't have to find
out the correct settings on their own.
Signed-off-by: Přemysl Janouch <p.janouch@gmail.com>
| Přemysl Janouch | 2014-01-08 | 1 | -2/+3 |
| * | Fix the example configuration•••"enable-git-clone" doesn't exist, replaced with "enable-http-clone".
Signed-off-by: Přemysl Janouch <p.janouch@gmail.com>
| Přemysl Janouch | 2014-01-08 | 1 | -1/+1 |
| * | Fix about-formatting.sh•••dash failed to parse the script.
Signed-off-by: Přemysl Janouch <p.janouch@gmail.com>
| Přemysl Janouch | 2014-01-08 | 1 | -1/+1 |
| * | Fix some spelling errors•••Signed-off-by: Přemysl Janouch <p.janouch@gmail.com>
| Přemysl Janouch | 2014-01-08 | 1 | -5/+5 |
| * | filters: highlight.sh: add css comments for highlight 2.6 and 3.8•••v2: add highlight 3.13 as present on Fedora 19
Signed-off-by: Ferry Huberts <ferry.huberts@pelagic.nl>
| Ferry Huberts | 2014-01-08 | 1 | -1/+63 |
| * | Add AUTHORS file•••Contains a list of contributors with more than 20 patches, to be updated
regularly.
Signed-off-by: Lukas Fleischer <cgit@crytocrack.de>
| Lukas Fleischer | 2014-01-08 | 1 | -0/+6 |
| * | Update copyright information•••* Name "cgit Development Team" as copyright holder to avoid listing
every single developer.
* Update copyright ranges.
Signed-off-by: Lukas Fleischer <cgit@crytocrack.de>
| Lukas Fleischer | 2014-01-08 | 23 | -31/+24 |
| * | git: update to 1.8.5•••Everything works just bumping the version in Makefile and commit hash
in submodule. No code changes required.
Signed-off-by: Lukas Fleischer <cgit@cryptocrack.de>
| Christian Hesse | 2014-01-08 | 2 | -1/+1 |
| * | Reduce line number bloat, fix hover effect•••Currently line numbers look like (for blob view and sdiff respectively):
<a class='no' id='n68' name='n68' href='#n68'>68</a>
<td class='lineno'><a class='no' href='...#n1' id='n1' name='n1'>1</a></td>
name=".." is unnecessary if the id attribute is set (this even applies
to IE6), so drop it. (aside, in HTML5, the name attribute is gone.)
The line number links can be selected through their parent classes, no
need for another class "no", so drop it too.
For a file with 2000 lines, this yields a saving of 40% (29% gzipped).
While at it, fix the hover effect of line numbers: now the line number
get a black background as was intended.
Signed-off-by: Peter Wu <lekensteyn@gmail.com>
Signed-off-by: Lukas Fleischer <cgit@cryptocrack.de>
| Peter Wu | 2014-01-08 | 4 | -10/+11 |
| * | plain: don't append charset for binary MIME types•••When outputting the Content-Type HTTP header we print the MIME type and
then append "; charset=<charset>" if the charset variable is non-null.
We don't want a charset when we have selected "application/octet-stream"
or when the user has specified a custom MIME type, since they may have
specified their own charset. To avoid this, make sure we set the page's
charset to NULL in ui-plain before we generate the HTTP headers.
Signed-off-by: John Keeping <john@keeping.me.uk>
Signed-off-by: Lukas Fleischer <cgit@cryptocrack.de>
| John Keeping | 2014-01-08 | 1 | -3/+8 |
| * | ui-log.c: Several simplifications•••* Use argv_array_pushf() for inserting formatted strings.
* Remove unneeded static strings.
* Replace "if" by "else if" for readability and speed.
Signed-off-by: Lukas Fleischer <cgit@cryptocrack.de>
| Lukas Fleischer | 2014-01-08 | 1 | -19/+9 |
| * | Use argv_array in place of vector•••Instead of using our own vector implementation, use argv_array from Git
which has been specifically designed for dynamic size argv arrays.
Drop vector.h and vector.c which are no longer needed.
Signed-off-by: Lukas Fleischer <cgit@cryptocrack.de>
| Lukas Fleischer | 2014-01-08 | 4 | -75/+15 |
| * | ui-stats.c: Remove unused macro•••Signed-off-by: Lukas Fleischer <cgit@cryptocrack.de>
| Lukas Fleischer | 2014-01-08 | 1 | -2/+0 |
| * | scan-tree.c: Remove unused macro•••This is no longer needed since commit fb3655df (use struct strbuf
instead of static buffers, 2013-04-06).
Signed-off-by: Lukas Fleischer <cgit@cryptocrack.de>
| Lukas Fleischer | 2014-01-08 | 1 | -2/+0 |
| * | ui-shared: Drop filepair_cb_raw() and helper•••Remove filepair_cb_raw() and all related functions. These are no longer
needed. We now use Git's internal functions for raw diff formatting
everywhere.
Signed-off-by: Lukas Fleischer <cgit@cryptocrack.de>
| Lukas Fleischer | 2013-09-14 | 2 | -73/+0 |
| * | ui-diff: Use diff_tree_sha1() for raw diff formatting•••Use Git's internal diff_tree_sha1() function for the /rawdiff/ command
instead of trying to recreate this functionality.
Signed-off-by: Lukas Fleischer <cgit@cryptocrack.de>
| Lukas Fleischer | 2013-09-14 | 1 | -2/+21 |
| * | tests/: Add t0110-rawdiff.sh•••This adds some basic tests for the /rawdiff/ command.
Signed-off-by: Lukas Fleischer <cgit@cryptocrack.de>
| Lukas Fleischer | 2013-08-26 | 1 | -0/+42 |
| * | t0108: Add tests for revision ranges•••Add tests to check whether generating multiple patches at once works.
Signed-off-by: Lukas Fleischer <cgit@cryptocrack.de>
| Lukas Fleischer | 2013-08-26 | 1 | -0/+17 |
