| Commit message (Expand) | Author | Age | Files | Lines |
|---|
| * | ui-shared: don't print path crumbs without a repo•••cgit_print_path_crumbs() can call repolink() which assumes that ctx.repo
is non-null. Currently we don't have any commands that set want_vpath
without also setting want_repo so it shouldn't be possible to fail this
test, but the check in cgit.c is in the wrong order so it is possible to
specify a query string like "?p=log&path=foo/bar" to end up here without
a valid repository.
This was found by American fuzzy lop [0].
[0] http://lcamtuf.coredump.cx/afl/
Signed-off-by: John Keeping <john@keeping.me.uk>
| John Keeping | 2017-08-10 | 1 | -1/+1 |
| * | ui-shared: replace 'unsigned char sha1[20]' with 'struct object_id oid'•••Upstream git is replacing 'unsigned char sha1[20]' with 'struct object_id
oid'. We have some code that can be changed independent from upstream. So
here we go...
| Christian Hesse | 2016-10-04 | 1 | -5/+5 |
| * | ui-shared: fix decl-after-statement warnings•••git.git's coding style avoids decl-after-statement and we generally try
to follow it but a few warnings have crept in recently. Fix the ones in
ui-shared.c
Signed-off-by: John Keeping <john@keeping.me.uk>
| John Keeping | 2016-10-01 | 1 | -5/+7 |
| * | ui-shared: fix segfault when defbranch is NULL•••Not sure if there's a better fix for this. defbranch is
NULL here on my setup when a crawler hit an invalid URL,
causing strcmp to segfault.
Signed-off-by: Eric Wong <normalperson@yhbt.net>
| Eric Wong | 2016-07-06 | 1 | -1/+1 |
| * | Avoid ambiguities when prettifying snapshot names•••When composing snapshot file names for a tag with a prefix of the form
v[0-9] (resp. V[0-9]), the leading "v" (resp. "V") is stripped. This
leads to conflicts if a tag with the stripped name already exists or if
there are tags only differing in the capitalization of the leading "v".
Make sure we do not strip the "v" in these cases.
Reported-by: Juuso Lapinlampi <wub@partyvan.eu>
Signed-off-by: Lukas Fleischer <lfleischer@lfos.de>
| Lukas Fleischer | 2016-07-05 | 1 | -5/+21 |
| * | Hosted on HTTPS now | Jason A. Donenfeld | 2016-06-07 | 1 | -1/+1 |
| * | forms: action should not be empty•••Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
| Jason A. Donenfeld | 2016-05-12 | 1 | -1/+1 |
| * | ui-shared: Remove a name attribute with an empty value•••The name attribute is optional in an input element, but it must not be
an empty value.
See: https://html.spec.whatwg.org/#attr-fe-name
See: https://html.spec.whatwg.org/#the-input-element
| Juuso Lapinlampi | 2016-05-12 | 1 | -1/+1 |
| * | ui-shared: HTML-ize DOCTYPE and <html>•••Get rid of the XHTML headers, bringing cgit slowly to the modern age of
HTML.
| Juuso Lapinlampi | 2016-05-12 | 1 | -3/+2 |
| * | ui-shared: Simplify cgit_print_error_page() logic | Juuso Lapinlampi | 2016-05-12 | 1 | -4/+2 |
| * | ui-shared: redirect should not exit early for cache•••Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
| Jason A. Donenfeld | 2016-02-26 | 1 | -1/+0 |
| * | tabs: do not use target=_blank | Jason A. Donenfeld | 2016-02-23 | 1 | -1/+1 |
| * | ui-shared: add homepage to tabs•••Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
| Jason A. Donenfeld | 2016-02-22 | 1 | -0/+5 |
| * | Avoid DATE_STRFTIME for long/short dates•••Git's DATE_STRFTIME ignores the timezone argument and just uses the
local timezone regardless of whether the "local" flag is set.
Since our existing FMT_LONGDATE and FMT_SHORTDATE are pretty-much
perfect matches to DATE_ISO8601 and DATE_SHORT, switch to taking a
date_mode_type directly in cgit_date_mode().
Signed-off-by: John Keeping <john@keeping.me.uk>
| John Keeping | 2016-02-08 | 1 | -7/+6 |
| * | ui-shared: remove cgit_print_date()•••There are no longer any users of this function.
Signed-off-by: John Keeping <john@keeping.me.uk>
| John Keeping | 2016-02-08 | 1 | -20/+0 |
| * | ui-shared: use show_date for footer timestamp•••Signed-off-by: John Keeping <john@keeping.me.uk>
| John Keeping | 2016-02-08 | 1 | -1/+1 |
| * | ui: show ages in the originator's timezone•••This affects the tooltip showing the full time and the case when a date
is sufficiently old to be shown in full rather than as an offset.
Signed-off-by: John Keeping <john@keeping.me.uk>
| John Keeping | 2016-02-08 | 1 | -11/+11 |
| * | ui-shared: add cgit_date_mode()•••This returns the correct mode value for use with Git's show_date() based
on the current CGit configuration and will be used in the following
patches.
Signed-off-by: John Keeping <john@keeping.me.uk>
| John Keeping | 2016-02-08 | 1 | -0/+9 |
| * | ui-shared: remove "format" from cgit_print_age()•••We never use any format other than FMT_SHORTDATE, so move that into the
function.
Signed-off-by: John Keeping <john@keeping.me.uk>
| John Keeping | 2016-02-08 | 1 | -2/+2 |
| * | ui-shared: prevent malicious filename from injecting headers | Jason A. Donenfeld | 2016-01-14 | 1 | -3/+5 |
| * | ui-shared: Avoid new line injection into redirect header | Jason A. Donenfeld | 2016-01-14 | 1 | -1/+3 |
| * | Fix segmentation fault in hc()•••The ctx.qry.page variable might be unset at this point, e.g. when an
invalid command is passed and cgit_print_pageheader() is called to show
an error message.
Signed-off-by: Lukas Fleischer <lfleischer@lfos.de>
| Lukas Fleischer | 2016-01-13 | 1 | -0/+3 |
| * | git: update to v2.7.0•••Update to git version v2.7.0.
* Upstream commit ed1c9977cb1b63e4270ad8bdf967a2d02580aa08 (Remove
get_object_hash.) changed API:
Convert all instances of get_object_hash to use an appropriate
reference to the hash member of the oid member of struct object.
This provides no functional change, as it is essentially a macro
substitution.
Signed-off-by: Christian Hesse <mail@eworm.de>
| Christian Hesse | 2016-01-13 | 1 | -1/+1 |
| * | ui-shared: fix resource leak: free allocation from cgit_hosturl•••Signed-off-by: Christian Hesse <mail@eworm.de>
| Christian Hesse | 2015-10-09 | 1 | -2/+3 |
| * | ui-shared: return value of cgit_hosturl is not const•••Signed-off-by: Christian Hesse <mail@eworm.de>
| Christian Hesse | 2015-10-09 | 1 | -3/+3 |
| * | ui-shared: fix resource leak: free allocation from cgit_currenturl•••Coverity-id: 13927
Signed-off-by: Christian Hesse <mail@eworm.de>
| Christian Hesse | 2015-10-09 | 1 | -3/+8 |
| * | ui-shared: return value of cgit_currenturl is not const•••Signed-off-by: Christian Hesse <mail@eworm.de>
| Christian Hesse | 2015-10-09 | 1 | -2/+2 |
| * | ui-shared: fix resource leak: free allocation from cgit_fileurl•••Coverity-id: 13918
Signed-off-by: Christian Hesse <mail@eworm.de>
| Christian Hesse | 2015-10-09 | 1 | -5/+11 |
| * | ui-shared: cache errors for "dynamic TTL"•••Most errors we generate are (potentially) transient, such as
non-existent object IDs so we don't want them to be cached forever.
Signed-off-by: John Keeping <john@keeping.me.uk>
| John Keeping | 2015-08-14 | 1 | -0/+1 |
| * | ui-shared: add cgit_print_layout_{start,end}()•••These will avoid needing to call three functions to start page layout in
subsequent patches when we move the layout setup into each individual
page.
Signed-off-by: John Keeping <john@keeping.me.uk>
| John Keeping | 2015-08-14 | 1 | -0/+12 |
| * | ui-shared: add cgit_print_error_page() function•••This will allow us to generate error responses with the correct HTTP
response code without needing all of the layout boilerplate.
Signed-off-by: John Keeping <john@keeping.me.uk>
| John Keeping | 2015-08-14 | 1 | -0/+14 |
| * | ui-shared: show full date in tooltip if longer ago than max_relative•••Commit caed6cb (ui-shared: show absolute time in tooltip for relative
dates, 2014-12-20) added a toolip when we show a relative time.
However, in some cases we show a short date (that is, the date but not
the time) if an event was sufficiently far in the past and that commit
did not update that case to add the same tooltip.
Signed-off-by: John Keeping <john@keeping.me.uk>
| John Keeping | 2015-08-13 | 1 | -0/+4 |
| * | ui-shared: use common function in print_rel_date()•••Signed-off-by: John Keeping <john@keeping.me.uk>
| John Keeping | 2015-08-13 | 1 | -10/+1 |
| * | ui-shared: extract date formatting to a function•••This will allow this code to be common with print_rel_date.
Signed-off-by: John Keeping <john@keeping.me.uk>
| John Keeping | 2015-08-13 | 1 | -4/+9 |
| * | redirect: cleanliness | Jason A. Donenfeld | 2015-08-13 | 1 | -2/+1 |
| * | log: allow users to follow a file•••Teach the "log" UI to behave in the same way as "git log --follow", when
given a suitable instruction by the user. The default behaviour remains
to show the log without following renames, but the follow behaviour can
be activated by following a link in the page header.
Follow is not the default because outputting merges in follow mode is
tricky ("git log --follow" will not show merges). We also disable the
graph in follow mode because the commit graph is not simplified so we
end up with frequent gaps in the graph and many lines that do not
connect with any commits we're actually showing.
We also teach the "diff" and "commit" UIs to respect the follow flag on
URLs, causing the single-file version of these UIs to detect renames.
This feature is needed only for commits that rename the path we're
interested in.
For commits before the file has been renamed (i.e. that appear later in
the log list) we change the file path in the links from the log to point
to the old name; this means that links to commits always limit by the
path known to that commit. If we didn't do this we would need to walk
down the log diff'ing every commit whenever we want to show a commit.
The drawback is that the "Log" link in the top bar of such a page links
to the log limited by the old name, so it will only show pre-rename
commits. I consider this a reasonable trade-off since the "Back" button
still works and the log matches the path displayed in the top bar.
Since following renames requires running diff on every commit we
consider, I've added a knob to the configuration file to globally
enable/disable this feature. Note that we may consider a large number
of commits the revision walking machinery no longer performs any path
limitation so we have to examine every commit until we find a page full
of commits that affect the target path or something related to it.
Suggested-by: René Neumann <necoro@necoro.eu>
Signed-off-by: John Keeping <john@keeping.me.uk>
| John Keeping | 2015-08-12 | 1 | -3/+25 |
| * | about: always ensure page has a trailing slash•••Otherwise we can't easily embed links to other /about/ pages.
Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
| Jason A. Donenfeld | 2015-08-12 | 1 | -0/+8 |
| * | git: update to v2.5.0•••Update to git version v2.5.0.
* Upstream commit 5455ee0573a22bb793a7083d593ae1ace909cd4c (Merge branch
'bc/object-id') changed API:
for_each_ref() callback functions were taught to name the objects
not with "unsigned char sha1[20]" but with "struct object_id".
* Upstream commit dcf692625ac569fefbe52269061230f4fde10e47 (path.c: make
get_pathname() call sites return const char *)
Signed-off-by: Christian Hesse <mail@eworm.de>
| Christian Hesse | 2015-08-12 | 1 | -1/+1 |
| * | ui-shared: allow remote refs in branch switcher•••Signed-off-by: Christian Hesse <mail@eworm.de>
| Christian Hesse | 2015-03-18 | 1 | -0/+2 |
| * | Remove no-op link from submodule entries•••Instead of linking to the current page ("href='#'"), do not add a link
to a submodule entry at all if the module-link setting is not used.
Signed-off-by: Lukas Fleischer <cgit@cryptocrack.de>
| Lukas Fleischer | 2015-03-13 | 1 | -17/+24 |
| * | ui-shared: currenturl should take into account leading slash | Jason A. Donenfeld | 2015-03-09 | 1 | -1/+5 |
| * | ui-shared: don't use an integer as a NULL pointer•••Signed-off-by: John Keeping <john@keeping.me.uk>
| John Keeping | 2015-03-09 | 1 | -1/+1 |
| * | ui-shared: avoid initializing static variable to zero•••Sparse complains that we are using a plain integer as a NULL pointer
here, but in fact we do not have to specify a value for this variable at
all since it has static storage duration and thus will be initialized to
NULL by the compiler.
Signed-off-by: John Keeping <john@keeping.me.uk>
| John Keeping | 2015-03-09 | 1 | -1/+1 |
| * | ui-shared: make cgit_doctype 'static'•••This is not used outside this file and is not declared.
Signed-off-by: John Keeping <john@keeping.me.uk>
| John Keeping | 2015-03-09 | 1 | -1/+1 |
| * | Avoid non-ANSI function declarations•••Sparse says things like:
warning: non-ANSI function declaration of function 'calc_ttl'
Signed-off-by: John Keeping <john@keeping.me.uk>
| John Keeping | 2015-03-09 | 1 | -6/+6 |
| * | Make root handling sane again. | Jason A. Donenfeld | 2015-03-03 | 1 | -12/+12 |
| * | ui-shared: Add current url helper function. | Jason A. Donenfeld | 2015-03-03 | 1 | -2/+9 |
| * | ui-shared: keep filter repolist page in pagination | Jason A. Donenfeld | 2015-03-03 | 1 | -3/+3 |
| * | ui-repolist: use ctx.qry.url instead of rooturl, in case we're filtering | Jason A. Donenfeld | 2015-03-03 | 1 | -1/+1 |
| * | ui-shared.c: Refactor add_clone_urls()•••Make use of strbuf_split_str() and strbuf lists to split clone URLs.
Signed-off-by: Lukas Fleischer <cgit@cryptocrack.de>
| Lukas Fleischer | 2015-02-05 | 1 | -22/+10 |
